Add default directories to the $OS_BUILD_ENV_PRESERVE path #14324
Conversation
| @@ -33,4 +33,10 @@ | |||
| # NOTE: only committed code is built. | |||
| source "$(dirname "${BASH_SOURCE}")/lib/init.sh" | |||
|
|
|||
| relative_bin_path="$( os::util::repository_relative_path "${OS_OUTPUT_BINPATH}" )" | |||
There was a problem hiding this comment.
Remember this is now going to download 1GB everytime you exit a container, so just be sure you want that pain.
There was a problem hiding this comment.
99% sure we do ... realistically people are using this to do builds locally pretty much 99.99999% of the time, they're not running other stuff as much.
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Users of `hack/env` almost always want to be retrieving build artifacts and script output artifacts from whatever process they trigger in the container. Instructing every user to set a `$OS_BUILD_ENV_PRESERVE` field is tedious, so we can default it when it is unset to contain the normal paths for binaries, releases, RPMs and script output. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/env-default
branch
from
5f89f5a to
1c1d65e
Compare
|
Evaluated for origin test up to 1c1d65e |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1703/) (Base Commit: 483738e) |
|
[merge] |
|
An option to opt-out would be nice. |
|
This only defaults if unset -- so |
|
ack
…On Tue, Jun 6, 2017 at 6:03 PM, Steve Kuznetsov ***@***.***> wrote:
This only defaults if unset -- so OS_BUILD_ENV_PRESERVE='' hack/env to
opt out
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14324 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADuFf8b5OcgyYnBilSMSSNvzbjWbSuQJks5sBXg7gaJpZM4NlH35>
.
|
|
@openshift-bot, the last build failed from the following flakes:
re[merge] |
|
Evaluated for origin merge up to 1c1d65e |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/909/) (Base Commit: bba14cc) (Image: devenv-rhel7_6320) |
Users of
hack/envalmost always want to be retrieving build artifactsand script output artifacts from whatever process they trigger in the
container. Instructing every user to set a
$OS_BUILD_ENV_PRESERVEfield is tedious, so we can default it when it is unset to contain the
normal paths for binaries, releases, RPMs and script output.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
@smarterclayton PTAL
[test]